OSDN Git Service

md/bitmap: revert a patch
authorShaohua Li <shli@fb.com>
Tue, 17 Oct 2017 02:03:44 +0000 (19:03 -0700)
committerShaohua Li <shli@fb.com>
Tue, 17 Oct 2017 02:03:44 +0000 (19:03 -0700)
This reverts commit 8031c3ddc70a. That patches doesn't work well if PAGE_SIZE >
4k. We will fix the original problem with a different approach.

Fix: 8031c3ddc70a(md/bitmap: copy correct data for bitmap super)
Reported-by: Joshua Kinard <kumba@gentoo.org>
Cc: stable@vger.kernel.org (4.10+)
Suggested-by: Neil Brown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/bitmap.c

index d212163..cae57b5 100644 (file)
@@ -625,7 +625,7 @@ re_read:
                err = read_sb_page(bitmap->mddev,
                                   offset,
                                   sb_page,
-                                  0, PAGE_SIZE);
+                                  0, sizeof(bitmap_super_t));
        }
        if (err)
                return err;
@@ -2123,7 +2123,7 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks,
        if (store.sb_page && bitmap->storage.sb_page)
                memcpy(page_address(store.sb_page),
                       page_address(bitmap->storage.sb_page),
-                      PAGE_SIZE);
+                      sizeof(bitmap_super_t));
        bitmap_file_unmap(&bitmap->storage);
        bitmap->storage = store;