OSDN Git Service

staging: fsl-mc: Remove unneeded else following a return
authorJanani Ravichandran <janani.rvchndrn@gmail.com>
Thu, 18 Feb 2016 22:22:50 +0000 (17:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 23:14:59 +0000 (15:14 -0800)
Remove unnecessary else when there is a return statement in the
corresponding if block. Coccinelle patch used:

@rule1@
expression e1;
@@

if (e1) { ... return ...; }
-       else{
        ...
-       }

@rule2@
expression e2;
statement s1;
@@

if(e2) { ... return ...; }
-       else
               s1

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/mc-bus.c

index c42bfac..5958e0f 100644 (file)
@@ -248,8 +248,7 @@ static bool fsl_mc_is_root_dprc(struct device *dev)
        fsl_mc_get_root_dprc(dev, &root_dprc_dev);
        if (!root_dprc_dev)
                return false;
-       else
-               return dev == root_dprc_dev;
+       return dev == root_dprc_dev;
 }
 
 static int get_dprc_icid(struct fsl_mc_io *mc_io,