OSDN Git Service

mtd: rawnand: mxc: remove useless checks in GET/SET_FEATURES functions
authorMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 19 Mar 2018 13:47:22 +0000 (14:47 +0100)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Tue, 20 Mar 2018 08:48:45 +0000 (09:48 +0100)
All the calls to the chip's hooks ->get/set_features() go through
the core's wrappers nand_get/set_features() that already do the
necessary checks about feature support. Remove these
checks from the mxc's functions.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/mtd/nand/raw/mxc_nand.c

index 6150165..944ecf0 100644 (file)
@@ -1428,11 +1428,6 @@ static int mxc_nand_set_features(struct mtd_info *mtd, struct nand_chip *chip,
        struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
        int i;
 
-       if (!chip->onfi_version ||
-           !(le16_to_cpu(chip->onfi_params.opt_cmd)
-             & ONFI_OPT_CMD_SET_GET_FEATURES))
-               return -EINVAL;
-
        host->buf_start = 0;
 
        for (i = 0; i < ONFI_SUBFEATURE_PARAM_LEN; ++i)
@@ -1453,11 +1448,6 @@ static int mxc_nand_get_features(struct mtd_info *mtd, struct nand_chip *chip,
        struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
        int i;
 
-       if (!chip->onfi_version ||
-           !(le16_to_cpu(chip->onfi_params.opt_cmd)
-             & ONFI_OPT_CMD_SET_GET_FEATURES))
-               return -EINVAL;
-
        host->devtype_data->send_cmd(host, NAND_CMD_GET_FEATURES, false);
        mxc_do_addr_cycle(mtd, addr, -1);
        host->devtype_data->send_page(mtd, NFC_OUTPUT);