OSDN Git Service

RDMA/iwcm: Remove useless check of netlink client validity
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 1 Jun 2017 09:42:36 +0000 (12:42 +0300)
committerLeon Romanovsky <leon@kernel.org>
Thu, 10 Aug 2017 10:17:26 +0000 (13:17 +0300)
RDMA netlink implementation guarantees that supplied
client number is in allowed range.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Chien Tin Tung <chien.tin.tung@intel.com>
drivers/infiniband/core/iwpm_util.c

index f13870e..32ca2aa 100644 (file)
@@ -54,8 +54,6 @@ static struct iwpm_admin_data iwpm_admin;
 int iwpm_init(u8 nl_client)
 {
        int ret = 0;
-       if (iwpm_valid_client(nl_client))
-               return -EINVAL;
        mutex_lock(&iwpm_admin_lock);
        if (atomic_read(&iwpm_admin.refcount) == 0) {
                iwpm_hash_bucket = kzalloc(IWPM_MAPINFO_HASH_SIZE *
@@ -383,15 +381,11 @@ int iwpm_get_nlmsg_seq(void)
 
 int iwpm_valid_client(u8 nl_client)
 {
-       if (nl_client >= RDMA_NL_NUM_CLIENTS)
-               return 0;
        return iwpm_admin.client_list[nl_client];
 }
 
 void iwpm_set_valid(u8 nl_client, int valid)
 {
-       if (nl_client >= RDMA_NL_NUM_CLIENTS)
-               return;
        iwpm_admin.client_list[nl_client] = valid;
 }