OSDN Git Service

mm/dmapool: switch from strlcpy to strscpy
authorZhiyuan Dai <daizhiyuan@phytium.com.cn>
Fri, 30 Apr 2021 05:57:55 +0000 (22:57 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 30 Apr 2021 18:20:39 +0000 (11:20 -0700)
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

Link: https://lkml.kernel.org/r/1613962050-14188-1-git-send-email-daizhiyuan@phytium.com.cn
Signed-off-by: Zhiyuan Dai <daizhiyuan@phytium.com.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/dmapool.c

index f379153..16483f8 100644 (file)
@@ -157,7 +157,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
        if (!retval)
                return retval;
 
-       strlcpy(retval->name, name, sizeof(retval->name));
+       strscpy(retval->name, name, sizeof(retval->name));
 
        retval->dev = dev;