OSDN Git Service

iwlwifi: return error if loading uCode failed
authorJohannes Berg <johannes.berg@intel.com>
Wed, 7 Mar 2012 17:52:22 +0000 (09:52 -0800)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 8 Mar 2012 18:59:49 +0000 (13:59 -0500)
In "iwlwifi: consolidate the start_device flow"
the code flow changed and the firmware is now
loaded by the transport layer, but the change
unfortunately lost error checking -- restore.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-trans-pcie.c

index 1c4fbcd..ef76a39 100644 (file)
@@ -1070,9 +1070,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
        iwl_write32(trans, CSR_UCODE_DRV_GP1_CLR, CSR_UCODE_SW_BIT_RFKILL);
 
        /* Load the given image to the HW */
-       iwl_load_given_ucode(trans, fw);
-
-       return 0;
+       return iwl_load_given_ucode(trans, fw);
 }
 
 /*