OSDN Git Service

perf script: Add missing closedir() calls
authorNamhyung Kim <namhyung@gmail.com>
Sat, 7 Jan 2012 17:25:25 +0000 (02:25 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sun, 8 Jan 2012 14:35:41 +0000 (12:35 -0200)
The get_script_path() calls opendir() but misses corresponding
closedir()'s. Add them.

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1325957132-10600-1-git-send-email-namhyung@gmail.com
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c

index fd1909a..bb68ddf 100644 (file)
@@ -1018,13 +1018,17 @@ static char *get_script_path(const char *script_root, const char *suffix)
                        __script_root = get_script_root(&script_dirent, suffix);
                        if (__script_root && !strcmp(script_root, __script_root)) {
                                free(__script_root);
+                               closedir(lang_dir);
+                               closedir(scripts_dir);
                                snprintf(script_path, MAXPATHLEN, "%s/%s",
                                         lang_path, script_dirent.d_name);
                                return strdup(script_path);
                        }
                        free(__script_root);
                }
+               closedir(lang_dir);
        }
+       closedir(scripts_dir);
 
        return NULL;
 }