OSDN Git Service

iio: adc: tsc2046: fix a warning message in tsc2046_adc_update_scan_mode()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 15 May 2021 09:51:52 +0000 (12:51 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 3 Jun 2021 17:24:12 +0000 (18:24 +0100)
These variables are unsigned so the condition can't be less than zero
and the warning message will never be printed.

Fixes: 9374e8f5a38d ("iio: adc: add ADC driver for the TI TSC2046 controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YJ+ZuO43TnguY5vq@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-tsc2046.c

index 89a818b..cf5373d 100644 (file)
@@ -398,7 +398,7 @@ static int tsc2046_adc_update_scan_mode(struct iio_dev *indio_dev,
        priv->xfer.len = size;
        priv->time_per_scan_us = size * 8 * priv->time_per_bit_ns / NSEC_PER_USEC;
 
-       if ((priv->scan_interval_us - priv->time_per_scan_us) < 0)
+       if (priv->scan_interval_us > priv->time_per_scan_us)
                dev_warn(&priv->spi->dev, "The scan interval (%d) is less then calculated scan time (%d)\n",
                         priv->scan_interval_us, priv->time_per_scan_us);