OSDN Git Service

Bluetooth: hci_bcm: add missing tty-device sanity check
authorJohan Hovold <johan@kernel.org>
Wed, 29 Mar 2017 16:15:27 +0000 (18:15 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 12 Apr 2017 20:02:39 +0000 (22:02 +0200)
Make sure to check the tty-device pointer before looking up the sibling
platform device to avoid dereferencing a NULL-pointer when the tty is
one end of a Unix98 pty.

Fixes: 0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")
Cc: stable <stable@vger.kernel.org> # 4.3
Cc: Frederic Danis <frederic.danis@linux.intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_bcm.c

index 04fe553..f87bfdf 100644 (file)
@@ -287,6 +287,9 @@ static int bcm_open(struct hci_uart *hu)
 
        hu->priv = bcm;
 
+       if (!hu->tty->dev)
+               goto out;
+
        mutex_lock(&bcm_device_lock);
        list_for_each(p, &bcm_device_list) {
                struct bcm_device *dev = list_entry(p, struct bcm_device, list);
@@ -307,7 +310,7 @@ static int bcm_open(struct hci_uart *hu)
        }
 
        mutex_unlock(&bcm_device_lock);
-
+out:
        return 0;
 }