OSDN Git Service

usb: xhci: tegra: use time64_t for printing timestamp
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Nov 2017 14:34:27 +0000 (15:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Nov 2017 18:08:53 +0000 (19:08 +0100)
The time_t type and time_to_tm() function are deprecated because
of y2038 problems. In this driver, they are used to pretty-print
the timestamp of the firmware build. This is fine as long as
we don't get a firmware build past 2038.

Converting to time64_t and time64_to_tm() avoids the deprecated
interfaces and works until 2106, when the firmware-defined
data structure overflows.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-tegra.c

index 74436f8..39b6e93 100644 (file)
@@ -771,7 +771,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
        struct device *dev = tegra->dev;
        const struct firmware *fw;
        unsigned long timeout;
-       time_t timestamp;
+       time64_t timestamp;
        struct tm time;
        u64 address;
        u32 value;
@@ -877,7 +877,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
        }
 
        timestamp = le32_to_cpu(header->fwimg_created_time);
-       time_to_tm(timestamp, 0, &time);
+       time64_to_tm(timestamp, 0, &time);
 
        dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
                 time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,