OSDN Git Service

mwifiex: ensure "disable auto DS" struct is initialized
authorBrian Norris <briannorris@chromium.org>
Tue, 25 Jul 2017 01:13:24 +0000 (18:13 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 28 Jul 2017 14:47:48 +0000 (17:47 +0300)
The .idle_time field *should* be unused, but technically, we're allowing
unitialized stack garbage to pass all the way through to the firmware
host command. Let's zero it out instead.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c

index 42997e0..43ecd62 100644 (file)
@@ -654,9 +654,9 @@ int mwifiex_get_bss_info(struct mwifiex_private *priv,
  */
 int mwifiex_disable_auto_ds(struct mwifiex_private *priv)
 {
-       struct mwifiex_ds_auto_ds auto_ds;
-
-       auto_ds.auto_ds = DEEP_SLEEP_OFF;
+       struct mwifiex_ds_auto_ds auto_ds = {
+               .auto_ds = DEEP_SLEEP_OFF,
+       };
 
        return mwifiex_send_cmd(priv, HostCmd_CMD_802_11_PS_MODE_ENH,
                                DIS_AUTO_PS, BITMAP_AUTO_DS, &auto_ds, true);