OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b8c19eb
)
[POWERPC] mpc5200: Fix null dereference if bestcomm fails to initialize
author
Grant Likely
<grant.likely@secretlab.ca>
Sat, 22 Mar 2008 03:41:05 +0000
(14:41 +1100)
committer
Paul Mackerras
<paulus@samba.org>
Mon, 24 Mar 2008 06:55:49 +0000
(17:55 +1100)
If the bestcomm initialization fails, calls to the task allocate
function should fail gracefully instead of oopsing with a NULL deref.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/sysdev/bestcomm/bestcomm.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/sysdev/bestcomm/bestcomm.c
b/arch/powerpc/sysdev/bestcomm/bestcomm.c
index
f589999
..
b18cab5
100644
(file)
--- a/
arch/powerpc/sysdev/bestcomm/bestcomm.c
+++ b/
arch/powerpc/sysdev/bestcomm/bestcomm.c
@@
-52,6
+52,10
@@
bcom_task_alloc(int bd_count, int bd_size, int priv_size)
int i, tasknum = -1;
struct bcom_task *tsk;
+ /* Don't try to do anything if bestcomm init failed */
+ if (!bcom_eng)
+ return NULL;
+
/* Get and reserve a task num */
spin_lock(&bcom_eng->lock);