OSDN Git Service

crypto: sl3516 - remove redundant initializations of pointers in_sg and out_sg
authorColin Ian King <colin.i.king@gmail.com>
Sun, 30 Jan 2022 23:05:15 +0000 (23:05 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 5 Feb 2022 04:27:10 +0000 (15:27 +1100)
Pointers in_sg and out_sg are being initialized with values that are
never read, they are being re-assigned the same values later on. The
initializations are redundant, remove them in preference to the later
assignments that are closer to when the pointers are being used.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/gemini/sl3516-ce-cipher.c

index c1c2b1d..53e3fef 100644 (file)
@@ -23,8 +23,8 @@ static bool sl3516_ce_need_fallback(struct skcipher_request *areq)
        struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(areq);
        struct sl3516_ce_cipher_tfm_ctx *op = crypto_skcipher_ctx(tfm);
        struct sl3516_ce_dev *ce = op->ce;
-       struct scatterlist *in_sg = areq->src;
-       struct scatterlist *out_sg = areq->dst;
+       struct scatterlist *in_sg;
+       struct scatterlist *out_sg;
        struct scatterlist *sg;
 
        if (areq->cryptlen == 0 || areq->cryptlen % 16) {