OSDN Git Service

powerpc/pseries: convert to use DEFINE_SEQ_ATTRIBUTE macro
authorLiu Shixin <liushixin2@huawei.com>
Wed, 16 Sep 2020 02:50:26 +0000 (10:50 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 18 Sep 2020 09:59:43 +0000 (19:59 +1000)
Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200916025026.3992835-1-liushixin2@huawei.com
arch/powerpc/platforms/pseries/hvCall_inst.c

index c40c62e..2c59b49 100644 (file)
@@ -70,31 +70,14 @@ static int hc_show(struct seq_file *m, void *p)
        return 0;
 }
 
-static const struct seq_operations hcall_inst_seq_ops = {
+static const struct seq_operations hcall_inst_sops = {
         .start = hc_start,
         .next  = hc_next,
         .stop  = hc_stop,
         .show  = hc_show
 };
 
-static int hcall_inst_seq_open(struct inode *inode, struct file *file)
-{
-       int rc;
-       struct seq_file *seq;
-
-       rc = seq_open(file, &hcall_inst_seq_ops);
-       seq = file->private_data;
-       seq->private = file_inode(file)->i_private;
-
-       return rc;
-}
-
-static const struct file_operations hcall_inst_seq_fops = {
-       .open = hcall_inst_seq_open,
-       .read = seq_read,
-       .llseek = seq_lseek,
-       .release = seq_release,
-};
+DEFINE_SEQ_ATTRIBUTE(hcall_inst);
 
 #define        HCALL_ROOT_DIR          "hcall_inst"
 #define CPU_NAME_BUF_SIZE      32
@@ -149,7 +132,7 @@ static int __init hcall_inst_init(void)
                snprintf(cpu_name_buf, CPU_NAME_BUF_SIZE, "cpu%d", cpu);
                debugfs_create_file(cpu_name_buf, 0444, hcall_root,
                                    per_cpu(hcall_stats, cpu),
-                                   &hcall_inst_seq_fops);
+                                   &hcall_inst_fops);
        }
 
        return 0;