OSDN Git Service

ata: sata_rcar: exclude setting of PHY registers in Gen3
authorMasaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
Mon, 6 Aug 2018 10:42:00 +0000 (12:42 +0200)
committerTejun Heo <tj@kernel.org>
Mon, 6 Aug 2018 17:25:34 +0000 (10:25 -0700)
According to documentation, setting of PHY registers is unnecessary with
R-Car Gen3. The registers are not even described. So, don't initialize
them.

Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
[wsa: updated commit message]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/sata_rcar.c

index 1ad168f..10ecb23 100644 (file)
@@ -830,10 +830,11 @@ static void sata_rcar_init_controller(struct ata_host *host)
                sata_rcar_gen1_phy_init(priv);
                break;
        case RCAR_GEN2_SATA:
-       case RCAR_GEN3_SATA:
        case RCAR_R8A7790_ES1_SATA:
                sata_rcar_gen2_phy_init(priv);
                break;
+       case RCAR_GEN3_SATA:
+               break;
        default:
                dev_warn(host->dev, "SATA phy is not initialized\n");
                break;
@@ -995,7 +996,6 @@ static int sata_rcar_resume(struct device *dev)
                return ret;
 
        if (priv->type == RCAR_GEN3_SATA) {
-               sata_rcar_gen2_phy_init(priv);
                sata_rcar_init_module(priv);
        } else {
                /* ack and mask */