OSDN Git Service

v4l: vsp1: Don't set WPF sink pointer
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Sun, 25 Jun 2017 17:12:36 +0000 (20:12 +0300)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Sat, 29 Jul 2017 20:46:56 +0000 (23:46 +0300)
The sink pointer is used to configure routing inside the VSP, and as
such must point to the next VSP entity in the pipeline. The WPF being a
pipeline terminal sink, its output route can't be configured. The
routing configuration code already handles this correctly without
referring to the sink pointer, which thus doesn't need to be set.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/vsp1/vsp1_drv.c

index 6b35e04..35087d5 100644 (file)
@@ -412,7 +412,6 @@ static int vsp1_create_entities(struct vsp1_device *vsp1)
                        }
 
                        list_add_tail(&video->list, &vsp1->videos);
-                       wpf->entity.sink = &video->video.entity;
                }
        }