OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6a7255e
)
USB: fix transvibrator disconnect race
author
Oliver Neukum
<oliver@neukum.name>
Fri, 24 Nov 2006 11:55:59 +0000
(12:55 +0100)
committer
Greg Kroah-Hartman
<gregkh@suse.de>
Wed, 20 Dec 2006 18:13:23 +0000
(10:13 -0800)
in disconnect you set the interface's private data to NULL. In your IO
methods you unconditionally follow the pointer into never never land.
Signed-off-by: Oliver Neukum <oliver@neukum.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/trancevibrator.c
patch
|
blob
|
history
diff --git
a/drivers/usb/misc/trancevibrator.c
b/drivers/usb/misc/trancevibrator.c
index
33cd91d
..
67e2fc2
100644
(file)
--- a/
drivers/usb/misc/trancevibrator.c
+++ b/
drivers/usb/misc/trancevibrator.c
@@
-120,8
+120,8
@@
static void tv_disconnect(struct usb_interface *interface)
struct trancevibrator *dev;
dev = usb_get_intfdata (interface);
- usb_set_intfdata(interface, NULL);
device_remove_file(&interface->dev, &dev_attr_speed);
+ usb_set_intfdata(interface, NULL);
usb_put_dev(dev->udev);
kfree(dev);
}