OSDN Git Service

ASoC: codecs: rt5682: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 16 Apr 2021 19:11:44 +0000 (14:11 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 19 Apr 2021 13:03:32 +0000 (14:03 +0100)
cppcheck warning:

sound/soc/codecs/rt5682.c:2404:42: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
   (pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST));
                                         ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20210416191144.27006-6-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5682.c

index 0e2a10e..a5aacfe 100644 (file)
@@ -2401,7 +2401,7 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
                        (pll_code.n_code << RT5682_PLL_N_SFT) | pll_code.k_code);
                snd_soc_component_write(component, RT5682_PLL_CTRL_2,
                        ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT) |
-                       (pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST));
+                       ((pll_code.m_bp << RT5682_PLL_M_BP_SFT) | RT5682_PLL_RST));
        }
 
        rt5682->pll_in[pll_id] = freq_in;