OSDN Git Service

f2fs: fix to migrate blocks correctly during defragment
authorChao Yu <yuchao0@huawei.com>
Mon, 29 Jul 2019 15:02:29 +0000 (23:02 +0800)
committer0ranko0P <ranko0p@outlook.com>
Tue, 24 Dec 2019 20:42:23 +0000 (04:42 +0800)
During defragment, we missed to trigger fragmented blocks migration
for below condition:

In defragment region:
- total number of valid blocks is smaller than 512;
- the tail part of the region are all holes;

In addtion, return zero to user via range->len if there is no
fragmented blocks.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c

index 06ff7b1..28575cc 100644 (file)
@@ -2382,8 +2382,10 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,
                map.m_lblk += map.m_len;
        }
 
-       if (!fragmented)
+       if (!fragmented) {
+               total = 0;
                goto out;
+       }
 
        sec_num = DIV_ROUND_UP(total, BLKS_PER_SEC(sbi));
 
@@ -2413,7 +2415,7 @@ do_map:
 
                if (!(map.m_flags & F2FS_MAP_FLAGS)) {
                        map.m_lblk = next_pgofs;
-                       continue;
+                       goto check;
                }
 
                set_inode_flag(inode, FI_DO_DEFRAG);
@@ -2437,8 +2439,8 @@ do_map:
                }
 
                map.m_lblk = idx;
-
-               if (idx < pg_end && cnt < blk_per_seg)
+check:
+               if (map.m_lblk < pg_end && cnt < blk_per_seg)
                        goto do_map;
 
                clear_inode_flag(inode, FI_DO_DEFRAG);