OSDN Git Service

Swap cid parameters
authorChris Manton <cmanton@google.com>
Thu, 31 Oct 2019 23:19:14 +0000 (16:19 -0700)
committerChris Manton <cmanton@google.com>
Fri, 1 Nov 2019 03:31:07 +0000 (20:31 -0700)
Confusingly the destination cid in this packet is actually the cid
of the remote and the source cid is the cid of the local.

Bug: 143697964
Test: Verified correct behavior on wireshark
Change-Id: I7c7b80458d91c2cbd48b5990ae9202fc062cd59b

gd/l2cap/classic/internal/signalling_manager.h

index be85873..0ec6a28 100644 (file)
@@ -73,7 +73,7 @@ class ClassicSignallingManager {
 
   void OnConnectionRequest(SignalId signal_id, Psm psm, Cid remote_cid);
 
-  void OnConnectionResponse(SignalId signal_id, Cid cid, Cid remote_cid, ConnectionResponseResult result,
+  void OnConnectionResponse(SignalId signal_id, Cid remote_cid, Cid cid, ConnectionResponseResult result,
                             ConnectionResponseStatus status);
 
   void OnDisconnectionRequest(SignalId signal_id, Cid cid, Cid remote_cid);