OSDN Git Service

misc/pvpanic: fix a NULL vs IS_ERR() check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 26 Nov 2018 08:12:29 +0000 (11:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 07:26:01 +0000 (08:26 +0100)
The devm_ioremap_resource() function doesn't return NULL, it returns
error pointers.

Fixes: 46f934c9a12f ("misc/pvpanic: add support to get pvpanic device info FDT")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/pvpanic.c

index 01241ec..595ac06 100644 (file)
@@ -140,8 +140,8 @@ static int pvpanic_mmio_probe(struct platform_device *pdev)
                return -EINVAL;
 
        base = devm_ioremap_resource(&pdev->dev, mem);
-       if (base == NULL)
-               return -EFAULT;
+       if (IS_ERR(base))
+               return PTR_ERR(base);
 
        atomic_notifier_chain_register(&panic_notifier_list,
                                       &pvpanic_panic_nb);