OSDN Git Service

arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 5 Aug 2022 09:23:15 +0000 (11:23 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 17 Aug 2022 17:07:40 +0000 (12:07 -0500)
The HID pin configurations belong in the HID nodes rather than i2c bus
node.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220805092317.4985-6-johan+linaro@kernel.org
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

index fbe874b..59869e7 100644 (file)
        clock-frequency = <400000>;
 
        pinctrl-names = "default";
-       pinctrl-0 = <&qup0_i2c4_default>, <&ts0_default>;
+       pinctrl-0 = <&qup0_i2c4_default>;
 
        status = "okay";
 
        touchscreen@10 {
                compatible = "hid-over-i2c";
                reg = <0x10>;
+
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 175 IRQ_TYPE_LEVEL_LOW>;
                vdd-supply = <&vreg_misc_3p3>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&ts0_default>;
        };
 };
 
        clock-frequency = <400000>;
 
        pinctrl-names = "default";
-       pinctrl-0 = <&qup2_i2c5_default>, <&kybd_default>, <&tpad_default>;
+       pinctrl-0 = <&qup2_i2c5_default>;
 
        status = "okay";
 
        touchpad@2c {
                compatible = "hid-over-i2c";
                reg = <0x2c>;
+
                hid-descr-addr = <0x20>;
                interrupts-extended = <&tlmm 182 IRQ_TYPE_LEVEL_LOW>;
                vdd-supply = <&vreg_misc_3p3>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&tpad_default>;
        };
 
        keyboard@68 {
                compatible = "hid-over-i2c";
                reg = <0x68>;
+
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
                vdd-supply = <&vreg_misc_3p3>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&kybd_default>;
        };
 };