OSDN Git Service

net: usb: aqc111: Initialize wol_cfg with memset in aqc111_suspend
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 29 Nov 2018 06:01:05 +0000 (23:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 1 Dec 2018 01:26:15 +0000 (17:26 -0800)
Clang warns:

drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
initialization of subobject [-Wmissing-braces]
                struct aqc111_wol_cfg wol_cfg = { 0 };
                                                  ^
                                                  {}
1 warning generated.

Use memset to initialize the object to take compiler instrumentation out
of the equation.

Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/aqc111.c

index f69d566..57f1c94 100644 (file)
@@ -1323,7 +1323,9 @@ static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
                              1, 1, &reg8);
 
        if (aqc111_data->wol_flags) {
-               struct aqc111_wol_cfg wol_cfg = { 0 };
+               struct aqc111_wol_cfg wol_cfg;
+
+               memset(&wol_cfg, 0, sizeof(struct aqc111_wol_cfg));
 
                aqc111_data->phy_cfg |= AQ_WOL;
                ether_addr_copy(wol_cfg.hw_addr, dev->net->dev_addr);