OSDN Git Service

drm/amd/powerplay: fix compile error with ARCH=arc
authorEvan Quan <evan.quan@amd.com>
Sun, 28 Jun 2020 11:12:42 +0000 (19:12 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 2 Jul 2020 16:02:57 +0000 (12:02 -0400)
Fix the compile error below:
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c: In function 'smu_v11_0_init_microcode':
>> arch/arc/include/asm/bug.h:22:2: error: implicit declaration of function 'pr_warn'; did you mean 'pci_warn'? [-Werror=implicit-function-declaration]
      22 |  pr_warn("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \
         |  ^~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:176:3: note: in expansion of macro 'BUG'
     176 |   BUG();

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Evan Quan <evan.quan@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/smu_v11_0.c

index f24983a..373e113 100644 (file)
@@ -173,7 +173,8 @@ int smu_v11_0_init_microcode(struct smu_context *smu)
                chip_name = "sienna_cichlid";
                break;
        default:
-               BUG();
+               dev_err(adev->dev, "Unsupported ASIC type %d\n", adev->asic_type);
+               return -EINVAL;
        }
 
        snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_smc.bin", chip_name);