OSDN Git Service

iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 7 Jan 2022 08:09:11 +0000 (08:09 +0000)
committerJoerg Roedel <jroedel@suse.de>
Mon, 28 Feb 2022 13:01:57 +0000 (14:01 +0100)
The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: 765a9d1d02b2 ("iommu/tegra-smmu: Fix mc errors on tegra124-nyan")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20220107080915.12686-1-linmq006@gmail.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/tegra-smmu.c

index e900e3c..2561ce8 100644 (file)
@@ -808,8 +808,10 @@ static struct tegra_smmu *tegra_smmu_find(struct device_node *np)
                return NULL;
 
        mc = platform_get_drvdata(pdev);
-       if (!mc)
+       if (!mc) {
+               put_device(&pdev->dev);
                return NULL;
+       }
 
        return mc->smmu;
 }