OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2edb7b5
)
uprobes: Kill the unnecesary filp != NULL check in __copy_insn()
author
Oleg Nesterov
<oleg@redhat.com>
Sun, 24 Mar 2013 17:45:44 +0000
(18:45 +0100)
committer
Oleg Nesterov
<oleg@redhat.com>
Thu, 4 Apr 2013 11:57:05 +0000
(13:57 +0200)
__copy_insn(filp) can only be called after valid_vma() returns T,
vma->vm_file passed as "filp" can not be NULL.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Anton Arapov <anton@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c
patch
|
blob
|
history
diff --git
a/kernel/events/uprobes.c
b/kernel/events/uprobes.c
index
ba6acfe
..
0938665
100644
(file)
--- a/
kernel/events/uprobes.c
+++ b/
kernel/events/uprobes.c
@@
-501,9
+501,6
@@
__copy_insn(struct address_space *mapping, struct file *filp, char *insn,
{
struct page *page;
- if (!filp)
- return -EINVAL;
-
if (!mapping->a_ops->readpage)
return -EIO;
/*