OSDN Git Service

powerpc/dma: remove unnecessary BUG()
authorChristophe Leroy <christophe.leroy@c-s.fr>
Wed, 28 Feb 2018 18:21:45 +0000 (19:21 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 3 Jun 2018 14:39:14 +0000 (00:39 +1000)
Direction is already checked in all calling functions in
include/linux/dma-mapping.h and also in called function __dma_sync()

So really no need to check it once more here.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/dma.c

index da20569..e1cd6e9 100644 (file)
@@ -235,8 +235,6 @@ static inline dma_addr_t dma_nommu_map_page(struct device *dev,
                                             enum dma_data_direction dir,
                                             unsigned long attrs)
 {
-       BUG_ON(dir == DMA_NONE);
-
        if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
                __dma_sync_page(page, offset, size, dir);