OSDN Git Service

net: dsa: mv88e6xxx: fix comments and macro names in mv88e6390_g1_mgmt_rsvd2cpu
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Mon, 3 Jun 2019 07:52:46 +0000 (07:52 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Jun 2019 17:07:43 +0000 (10:07 -0700)
The macros have an extraneous '800' (after 0180C2 there should be just
six nibbles, with X representing one), while the comments have
interchanged c2 and 80 and an extra :00.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/global1.c
drivers/net/dsa/mv88e6xxx/global1.h

index 38e399e..b5ceff2 100644 (file)
@@ -379,26 +379,26 @@ int mv88e6390_g1_mgmt_rsvd2cpu(struct mv88e6xxx_chip *chip)
        u16 ptr;
        int err;
 
-       /* 01:c2:80:00:00:00:00-01:c2:80:00:00:00:07 are Management */
-       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XLO;
+       /* 01:80:c2:00:00:00-01:80:c2:00:00:07 are Management */
+       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XLO;
        err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);
        if (err)
                return err;
 
-       /* 01:c2:80:00:00:00:08-01:c2:80:00:00:00:0f are Management */
-       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XHI;
+       /* 01:80:c2:00:00:08-01:80:c2:00:00:0f are Management */
+       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XHI;
        err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);
        if (err)
                return err;
 
-       /* 01:c2:80:00:00:00:20-01:c2:80:00:00:00:27 are Management */
-       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XLO;
+       /* 01:80:c2:00:00:20-01:80:c2:00:00:27 are Management */
+       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XLO;
        err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);
        if (err)
                return err;
 
-       /* 01:c2:80:00:00:00:28-01:c2:80:00:00:00:2f are Management */
-       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XHI;
+       /* 01:80:c2:00:00:28-01:80:c2:00:00:2f are Management */
+       ptr = MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XHI;
        err = mv88e6390_g1_monitor_write(chip, ptr, 0xff);
        if (err)
                return err;
index bef0133..2f195a0 100644 (file)
 #define MV88E6390_G1_MONITOR_MGMT_CTL                          0x1a
 #define MV88E6390_G1_MONITOR_MGMT_CTL_UPDATE                   0x8000
 #define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_MASK                 0x3f00
-#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XLO    0x0000
-#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000000XHI    0x0100
-#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XLO    0x0200
-#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C280000002XHI    0x0300
+#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XLO       0x0000
+#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200000XHI       0x0100
+#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XLO       0x0200
+#define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_0180C200002XHI       0x0300
 #define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_INGRESS_DEST         0x2000
 #define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_EGRESS_DEST          0x2100
 #define MV88E6390_G1_MONITOR_MGMT_CTL_PTR_CPU_DEST             0x3000