OSDN Git Service

pinctrl-st: fix of_irq_to_resource() result check
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sat, 29 Jul 2017 18:07:07 +0000 (21:07 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 14 Aug 2017 13:01:02 +0000 (15:01 +0200)
of_irq_to_resource() has recently been fixed to return negative error #'s
along with 0 in case of failure, however the ST driver still only regards
0 as failure indication -- fix it up.

Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-st.c

index 7ac8b1e..70dd2e3 100644 (file)
@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
         *      [irqN]----> [gpio-bank (n)]
         */
 
-       if (of_irq_to_resource(np, 0, &irq_res)) {
+       if (of_irq_to_resource(np, 0, &irq_res) > 0) {
                gpio_irq = irq_res.start;
                gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip,
                                             gpio_irq, st_gpio_irq_handler);