OSDN Git Service

mmc: pxamci: Fix an error handling path in pxamci_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 26 Jul 2022 19:15:43 +0000 (21:15 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 15 Aug 2022 13:53:50 +0000 (15:53 +0200)
The commit in Fixes: has moved some code around without updating gotos to
the error handling path.

Update it now and release some resources if pxamci_of_init() fails.

Fixes: fa3a5115469c ("mmc: pxamci: call mmc_of_parse()")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/6d75855ad4e2470e9ed99e0df21bc30f0c925a29.1658862932.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/pxamci.c

index 0db9490..37bf362 100644 (file)
@@ -648,7 +648,7 @@ static int pxamci_probe(struct platform_device *pdev)
 
        ret = pxamci_of_init(pdev, mmc);
        if (ret)
-               return ret;
+               goto out;
 
        host = mmc_priv(mmc);
        host->mmc = mmc;