OSDN Git Service

netfilter: nfnetlink_acct: fix incomplete dumping of objects
authorPablo Neira Ayuso <pablo@netfilter.org>
Sat, 1 Jun 2013 13:31:40 +0000 (15:31 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 5 Jun 2013 10:36:36 +0000 (12:36 +0200)
Fix broken incomplete object dumping if the list of objects does not
fit into one single netlink message.

Reported-by: Gabriel Lazar <Gabriel.Lazar@com.utcluj.ro>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nfnetlink_acct.c

index dc3fd5d..c7b6d46 100644 (file)
@@ -149,9 +149,12 @@ nfnl_acct_dump(struct sk_buff *skb, struct netlink_callback *cb)
 
        rcu_read_lock();
        list_for_each_entry_rcu(cur, &nfnl_acct_list, head) {
-               if (last && cur != last)
-                       continue;
+               if (last) {
+                       if (cur != last)
+                               continue;
 
+                       last = NULL;
+               }
                if (nfnl_acct_fill_info(skb, NETLINK_CB(cb->skb).portid,
                                       cb->nlh->nlmsg_seq,
                                       NFNL_MSG_TYPE(cb->nlh->nlmsg_type),