OSDN Git Service

hugetlb_cgroup: use helper macro NUMA_NO_NODE
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Jul 2022 08:01:05 +0000 (16:01 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 03:25:53 +0000 (20:25 -0700)
It's better to use NUMA_NO_NODE instead of magic number -1. Minor
readability improvement.

Link: https://lkml.kernel.org/r/20220729080106.12752-5-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb_cgroup.c

index 01a7094..2affccf 100644 (file)
@@ -154,9 +154,9 @@ hugetlb_cgroup_css_alloc(struct cgroup_subsys_state *parent_css)
         * function.
         */
        for_each_node(node) {
-               /* Set node_to_alloc to -1 for offline nodes. */
+               /* Set node_to_alloc to NUMA_NO_NODE for offline nodes. */
                int node_to_alloc =
-                       node_state(node, N_NORMAL_MEMORY) ? node : -1;
+                       node_state(node, N_NORMAL_MEMORY) ? node : NUMA_NO_NODE;
                h_cgroup->nodeinfo[node] =
                        kzalloc_node(sizeof(struct hugetlb_cgroup_per_node),
                                     GFP_KERNEL, node_to_alloc);