OSDN Git Service

drm/omap: Use ERR_CAST directly instead of ERR_PTR(PTR_ERR())
authorzhong jiang <zhongjiang@huawei.com>
Tue, 11 Sep 2018 11:54:35 +0000 (19:54 +0800)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 2 Oct 2018 06:36:56 +0000 (09:36 +0300)
We prefer to use ERR_CAST to do so.
The issue is detected with the help of Coccinelle.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/gpu/drm/omapdrm/dss/dss.c

index 19fc4df..1aaf260 100644 (file)
@@ -947,7 +947,7 @@ dss_debugfs_create_file(struct dss_device *dss, const char *name,
                                &dss_debug_fops);
        if (IS_ERR(d)) {
                kfree(entry);
-               return ERR_PTR(PTR_ERR(d));
+               return ERR_CAST(d);
        }
 
        entry->dentry = d;