OSDN Git Service

IB/ipoib: Fix error return code in ipoib_dev_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 11 Jul 2018 13:15:42 +0000 (13:15 +0000)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 24 Jul 2018 20:56:37 +0000 (14:56 -0600)
Fix to return a negative error code from the ipoib_neigh_hash_init()
error handling case instead of 0, as done elsewhere in this function.

Fixes: 515ed4f3aab4 ("IB/IPoIB: Separate control and data related initializations")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/ulp/ipoib/ipoib_main.c

index 012c9e3..82f0e38 100644 (file)
@@ -1791,7 +1791,8 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port)
                goto out_free_pd;
        }
 
-       if (ipoib_neigh_hash_init(priv) < 0) {
+       ret = ipoib_neigh_hash_init(priv);
+       if (ret) {
                pr_warn("%s failed to init neigh hash\n", dev->name);
                goto out_dev_uninit;
        }