OSDN Git Service

dpaa2-eth: Simplify bool conversion
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 15 Feb 2022 01:09:13 +0000 (09:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Feb 2022 14:39:12 +0000 (14:39 +0000)
Fix the following coccicheck warnings:
./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1199:42-47: WARNING:
conversion to bool not needed here
./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1218:54-59: WARNING:
conversion to bool not needed here

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index c4a48e6..3e709c8 100644 (file)
@@ -1196,7 +1196,7 @@ static int dpaa2_eth_build_gso_fd(struct dpaa2_eth_priv *priv,
                /* Setup the SG entry for the header */
                dpaa2_sg_set_addr(sgt, tso_hdr_dma);
                dpaa2_sg_set_len(sgt, hdr_len);
-               dpaa2_sg_set_final(sgt, data_left > 0 ? false : true);
+               dpaa2_sg_set_final(sgt, data_left <= 0);
 
                /* Compose the SG entries for each fragment of data */
                num_sge = 1;
@@ -1215,7 +1215,7 @@ static int dpaa2_eth_build_gso_fd(struct dpaa2_eth_priv *priv,
                        }
                        dpaa2_sg_set_addr(sgt, addr);
                        dpaa2_sg_set_len(sgt, size);
-                       dpaa2_sg_set_final(sgt, size == data_left ? true : false);
+                       dpaa2_sg_set_final(sgt, size == data_left);
 
                        num_sge++;