OSDN Git Service

PM: runtime: Replace pm_runtime_callbacks_present()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 28 May 2020 14:45:14 +0000 (16:45 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 29 May 2020 16:03:12 +0000 (18:03 +0200)
The name of pm_runtime_callbacks_present() is confusing, because
it suggests that the device has PM-runtime callbacks if 'true' is
returned by that function, but in fact that may not be the case,
so replace it with pm_runtime_has_no_callbacks() which is not
ambiguous.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/base/power/sysfs.c
include/linux/pm_runtime.h

index 2b99fe1..24d25cf 100644 (file)
@@ -666,7 +666,7 @@ int dpm_sysfs_add(struct device *dev)
        if (rc)
                return rc;
 
-       if (pm_runtime_callbacks_present(dev)) {
+       if (!pm_runtime_has_no_callbacks(dev)) {
                rc = sysfs_merge_group(&dev->kobj, &pm_runtime_attr_group);
                if (rc)
                        goto err_out;
@@ -709,7 +709,7 @@ int dpm_sysfs_change_owner(struct device *dev, kuid_t kuid, kgid_t kgid)
        if (rc)
                return rc;
 
-       if (pm_runtime_callbacks_present(dev)) {
+       if (!pm_runtime_has_no_callbacks(dev)) {
                rc = sysfs_group_change_owner(
                        &dev->kobj, &pm_runtime_attr_group, kuid, kgid);
                if (rc)
index 3bdcbce..3dbc207 100644 (file)
@@ -102,9 +102,9 @@ static inline bool pm_runtime_enabled(struct device *dev)
        return !dev->power.disable_depth;
 }
 
-static inline bool pm_runtime_callbacks_present(struct device *dev)
+static inline bool pm_runtime_has_no_callbacks(struct device *dev)
 {
-       return !dev->power.no_callbacks;
+       return dev->power.no_callbacks;
 }
 
 static inline void pm_runtime_mark_last_busy(struct device *dev)