OSDN Git Service

net: ethernet: sun4i-emac: Fix an error handling path in emac_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 15 Jan 2022 12:45:03 +0000 (13:45 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Jan 2022 22:34:52 +0000 (22:34 +0000)
A dma_request_chan() call is hidden in emac_configure_dma().
It must be released in the probe if an error occurs, as already done in
the remove function.

Add the corresponding dma_release_channel() call.

Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/allwinner/sun4i-emac.c

index 74635a6..621ce74 100644 (file)
@@ -1072,6 +1072,7 @@ out_clk_disable_unprepare:
        clk_disable_unprepare(db->clk);
 out_dispose_mapping:
        irq_dispose_mapping(ndev->irq);
+       dma_release_channel(db->rx_chan);
 out_iounmap:
        iounmap(db->membase);
 out: