OSDN Git Service

fm10k: explicitly return 0 on success path in function
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 8 Jul 2019 23:12:32 +0000 (16:12 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sun, 4 Aug 2019 11:32:47 +0000 (04:32 -0700)
In the fm10k_handle_resume function, return 0 explicitly at the end of
the function instead of returning the err value.

This was detected by cppcheck and resolves the following style warning
produced by that tool:

[fm10k_pci.c:2768] -> [fm10k_pci.c:2787]: (warning) Identical condition
'err', second condition is always false

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pci.c

index 9522e9f..73928db 100644 (file)
@@ -2340,7 +2340,7 @@ static int fm10k_handle_resume(struct fm10k_intfc *interface)
        /* Restart the MAC/VLAN request queue in-case of outstanding events */
        fm10k_macvlan_schedule(interface);
 
-       return err;
+       return 0;
 }
 
 /**