OSDN Git Service

media: mtk-jpegdec: add missing destroy_workqueue()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 10 Nov 2022 15:05:59 +0000 (23:05 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 18 Nov 2022 14:48:17 +0000 (15:48 +0100)
destroy_workqueue() needs be called to when driver is
unloading, fix it by using devm_add_action_or_reset()
to make workqueuedevice-managed.

Fixes: dedc21500334 ("media: mtk-jpegdec: add jpeg decode worker interface")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c

index d98f4cd..8c07fa0 100644 (file)
@@ -580,6 +580,11 @@ static int mtk_jpegdec_hw_init_irq(struct mtk_jpegdec_comp_dev *dev)
        return 0;
 }
 
+static void mtk_jpegdec_destroy_workqueue(void *data)
+{
+       destroy_workqueue(data);
+}
+
 static int mtk_jpegdec_hw_probe(struct platform_device *pdev)
 {
        struct mtk_jpegdec_clk *jpegdec_clk;
@@ -614,6 +619,11 @@ static int mtk_jpegdec_hw_probe(struct platform_device *pdev)
                                                                | WQ_FREEZABLE);
                if (!master_dev->workqueue)
                        return -EINVAL;
+
+               ret = devm_add_action_or_reset(&pdev->dev, mtk_jpegdec_destroy_workqueue,
+                                              master_dev->workqueue);
+               if (ret)
+                       return ret;
        }
 
        atomic_set(&master_dev->dechw_rdy, MTK_JPEGDEC_HW_MAX);