OSDN Git Service

Fix minor issue in vkCreateInstance extension loop
authorHernan Liatis <hliatis@google.com>
Sat, 23 Feb 2019 01:46:19 +0000 (17:46 -0800)
committerHernan Liatis <hliatis@google.com>
Mon, 25 Feb 2019 21:03:00 +0000 (21:03 +0000)
Extension checking in vkCreateInstance would simply
loop through the first extension requested. This
bug did not show up earlier (or at all) because
erroneous situations would cause early exits in
the loader.

Bug: b/125943360
Change-Id: Id664f46d09dce1b3530670ae826314b26797b5be
Reviewed-on: https://swiftshader-review.googlesource.com/c/25368
Tested-by: Hernan Liatis <hliatis@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
src/Vulkan/libVulkan.cpp

index 3b3a345..8822500 100644 (file)
@@ -107,7 +107,7 @@ VKAPI_ATTR VkResult VKAPI_CALL vkCreateInstance(const VkInstanceCreateInfo* pCre
 
        for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; ++i)
        {
-               const char* currentExtensionName = *(pCreateInfo->ppEnabledExtensionNames);
+               const char* currentExtensionName = pCreateInfo->ppEnabledExtensionNames[i];
                uint32_t extensionPropertiesCount = sizeof(instanceExtensionProperties) / sizeof(instanceExtensionProperties[0]);
                bool foundExtension = false;