OSDN Git Service

ethernet: micrel: Use DIV_ROUND_CLOSEST directly to make it readable
authorzhong jiang <zhongjiang@huawei.com>
Thu, 5 Sep 2019 15:53:48 +0000 (23:53 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Sep 2019 15:17:02 +0000 (17:17 +0200)
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/micrel/ksz884x.c

index 3103446..e102e15 100644 (file)
@@ -2166,7 +2166,7 @@ static void sw_get_broad_storm(struct ksz_hw *hw, u8 *percent)
        num = (data & BROADCAST_STORM_RATE_HI);
        num <<= 8;
        num |= (data & BROADCAST_STORM_RATE_LO) >> 8;
-       num = (num * 100 + BROADCAST_STORM_VALUE / 2) / BROADCAST_STORM_VALUE;
+       num = DIV_ROUND_CLOSEST(num * 100, BROADCAST_STORM_VALUE);
        *percent = (u8) num;
 }