OSDN Git Service

fbdev/aty128fb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:30 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:35 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-6-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/aty/aty128fb.c

index 850d5c0..ea24f81 100644 (file)
@@ -1098,10 +1098,8 @@ config FB_RADEON_DEBUG
 config FB_ATY128
        tristate "ATI Rage128 display support"
        depends on FB && PCI
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
        select FB_BACKLIGHT if FB_ATY128_BACKLIGHT
+       select FB_IOMEM_HELPERS
        select FB_MACMODES if PPC_PMAC
        select VIDEO_NOMODESET
        help
index b44fc78..f4de11f 100644 (file)
@@ -504,6 +504,7 @@ static void aty128_bl_set_power(struct fb_info *info, int power);
 
 static const struct fb_ops aty128fb_ops = {
        .owner          = THIS_MODULE,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_check_var   = aty128fb_check_var,
        .fb_set_par     = aty128fb_set_par,
        .fb_setcolreg   = aty128fb_setcolreg,
@@ -511,9 +512,6 @@ static const struct fb_ops aty128fb_ops = {
        .fb_blank       = aty128fb_blank,
        .fb_ioctl       = aty128fb_ioctl,
        .fb_sync        = aty128fb_sync,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
 };
 
     /*