OSDN Git Service

net: dsa: tag_qca: let DSA core deal with TX reallocation
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sun, 1 Nov 2020 19:16:12 +0000 (21:16 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Nov 2020 01:41:16 +0000 (17:41 -0800)
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.

Cc: John Crispin <john@phrozen.org>
Cc: Alexander Lobakin <alobakin@pm.me>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_qca.c

index 1b9e850..88181b5 100644 (file)
@@ -34,9 +34,6 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev)
        __be16 *phdr;
        u16 hdr;
 
-       if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
-               return NULL;
-
        skb_push(skb, QCA_HDR_LEN);
 
        memmove(skb->data, skb->data + QCA_HDR_LEN, 2 * ETH_ALEN);