OSDN Git Service

libnvdimm, bus: Check id immediately following ida_simple_get
authorOcean He <hehy1@lenovo.com>
Fri, 3 Aug 2018 12:08:33 +0000 (08:08 -0400)
committerDan Williams <dan.j.williams@intel.com>
Mon, 10 Dec 2018 23:41:34 +0000 (15:41 -0800)
The id check was not executed immediately following ida_simple_get. Just
change the codes position, without function change.

Signed-off-by: Ocean He <hehy1@lenovo.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/bus.c

index f1fb399..36da259 100644 (file)
@@ -344,12 +344,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,
        INIT_LIST_HEAD(&nvdimm_bus->mapping_list);
        init_waitqueue_head(&nvdimm_bus->probe_wait);
        nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL);
-       mutex_init(&nvdimm_bus->reconfig_mutex);
-       badrange_init(&nvdimm_bus->badrange);
        if (nvdimm_bus->id < 0) {
                kfree(nvdimm_bus);
                return NULL;
        }
+       mutex_init(&nvdimm_bus->reconfig_mutex);
+       badrange_init(&nvdimm_bus->badrange);
        nvdimm_bus->nd_desc = nd_desc;
        nvdimm_bus->dev.parent = parent;
        nvdimm_bus->dev.release = nvdimm_bus_release;