OSDN Git Service

drm: ast: fix double __iomem sparse warning
authorRandy Dunlap <rdunlap@infradead.org>
Tue, 18 Aug 2020 20:28:11 +0000 (13:28 -0700)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 19 Aug 2020 07:14:40 +0000 (09:14 +0200)
sparse complains about having 2 "__iomem" attributes on the same line
where only one is needed since the first one applies to everything
up to the ending ';'.
However, to make it clear(er) that both of these pointers are
"__iomem", use separate lines for them.

../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: warning: duplicate [noderef]
../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: error: multiple address space given: __iomem & __iomem

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Dave Airlie <airlied@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/a8185578-a69a-16b0-6fdf-f4e46bc4f61f@infradead.org
drivers/gpu/drm/ast/ast_cursor.c

index 6c96f74..e0f4613 100644 (file)
@@ -253,7 +253,8 @@ void ast_cursor_show(struct ast_private *ast, int x, int y,
                     unsigned int offset_x, unsigned int offset_y)
 {
        u8 x_offset, y_offset;
-       u8 __iomem *dst, __iomem *sig;
+       u8 __iomem *dst;
+       u8 __iomem *sig;
        u8 jreg;
 
        dst = ast->cursor.vaddr[ast->cursor.next_index];