OSDN Git Service

staging: rtl8723bs: remove unneeded conversion to bool
authorSaiyam Doshi <saiyamdoshi.in@gmail.com>
Thu, 12 Sep 2019 14:53:46 +0000 (20:23 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Sep 2019 19:57:56 +0000 (21:57 +0200)
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.

This issue found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Link: https://lore.kernel.org/r/20190912145346.GA9013@SD.eic.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

index 814b7a6..c7170a2 100644 (file)
@@ -2922,7 +2922,8 @@ int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *pssid,
        int i = 0;
 
        do {
-               ret = _issue_probereq(padapter, pssid, da, ch, append_wps, wait_ms > 0?true:false);
+               ret = _issue_probereq(padapter, pssid, da, ch, append_wps,
+                                     wait_ms > 0);
 
                i++;
 
@@ -3513,7 +3514,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow
        }
 
        do {
-               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0?true:false);
+               ret = _issue_nulldata(padapter, da, power_mode, wait_ms > 0);
 
                i++;
 
@@ -3661,7 +3662,7 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int
                da = get_my_bssid(&(pmlmeinfo->network));
 
        do {
-               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0?true:false);
+               ret = _issue_qos_nulldata(padapter, da, tid, wait_ms > 0);
 
                i++;
 
@@ -3769,7 +3770,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reason, int
        int i = 0;
 
        do {
-               ret = _issue_deauth(padapter, da, reason, wait_ms > 0?true:false);
+               ret = _issue_deauth(padapter, da, reason, wait_ms > 0);
 
                i++;