OSDN Git Service

ath9k: remove permissions from debugfs files
authorJiri Slaby <jirislaby@gmail.com>
Sun, 28 Jun 2009 21:25:28 +0000 (23:25 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 10 Jul 2009 19:02:26 +0000 (15:02 -0400)
Don't allow users to open debugfs files, because it can cause oopses.

When a user opens some file, driver unlinks it and frees the
corresponding structure, we will dereference freed memory.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/debug.c

index 6d20725..9f99f00 100644 (file)
@@ -500,31 +500,31 @@ int ath9k_init_debug(struct ath_softc *sc)
                goto err;
 
        sc->debug.debugfs_debug = debugfs_create_file("debug",
-               S_IRUGO | S_IWUSR, sc->debug.debugfs_phy, sc, &fops_debug);
+               S_IRUSR | S_IWUSR, sc->debug.debugfs_phy, sc, &fops_debug);
        if (!sc->debug.debugfs_debug)
                goto err;
 
-       sc->debug.debugfs_dma = debugfs_create_file("dma", S_IRUGO,
+       sc->debug.debugfs_dma = debugfs_create_file("dma", S_IRUSR,
                                       sc->debug.debugfs_phy, sc, &fops_dma);
        if (!sc->debug.debugfs_dma)
                goto err;
 
        sc->debug.debugfs_interrupt = debugfs_create_file("interrupt",
-                                                    S_IRUGO,
+                                                    S_IRUSR,
                                                     sc->debug.debugfs_phy,
                                                     sc, &fops_interrupt);
        if (!sc->debug.debugfs_interrupt)
                goto err;
 
        sc->debug.debugfs_rcstat = debugfs_create_file("rcstat",
-                                                 S_IRUGO,
+                                                 S_IRUSR,
                                                  sc->debug.debugfs_phy,
                                                  sc, &fops_rcstat);
        if (!sc->debug.debugfs_rcstat)
                goto err;
 
        sc->debug.debugfs_wiphy = debugfs_create_file(
-               "wiphy", S_IRUGO | S_IWUSR, sc->debug.debugfs_phy, sc,
+               "wiphy", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy, sc,
                &fops_wiphy);
        if (!sc->debug.debugfs_wiphy)
                goto err;