OSDN Git Service

ath10k: retrieve MAC address from system firmware if provided
authorBrian Norris <briannorris@chromium.org>
Tue, 28 Aug 2018 16:48:17 +0000 (19:48 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 3 Sep 2018 16:53:18 +0000 (19:53 +0300)
Devices may provide their own MAC address via system firmware (e.g.,
device tree), especially in the case where the device doesn't have a
useful EEPROM on which to store its MAC address (e.g., for integrated
Wifi).

Use the generic device helper to retrieve the MAC address, and (if
present) honor it above the MAC address advertised by the card.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/core.c
drivers/net/wireless/ath/ath10k/wmi.c

index ebc2138..f5f71c0 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/module.h>
 #include <linux/firmware.h>
 #include <linux/of.h>
+#include <linux/property.h>
 #include <linux/dmi.h>
 #include <linux/ctype.h>
 #include <asm/byteorder.h>
@@ -2617,6 +2618,8 @@ static int ath10k_core_probe_fw(struct ath10k *ar)
                ath10k_debug_print_board_info(ar);
        }
 
+       device_get_mac_address(ar->dev, ar->mac_addr, sizeof(ar->mac_addr));
+
        ret = ath10k_core_init_firmware_features(ar);
        if (ret) {
                ath10k_err(ar, "fatal problem with firmware features: %d\n",
index 40ce0e4..212005c 100644 (file)
@@ -5455,7 +5455,8 @@ int ath10k_wmi_event_ready(struct ath10k *ar, struct sk_buff *skb)
                   arg.mac_addr,
                   __le32_to_cpu(arg.status));
 
-       ether_addr_copy(ar->mac_addr, arg.mac_addr);
+       if (is_zero_ether_addr(ar->mac_addr))
+               ether_addr_copy(ar->mac_addr, arg.mac_addr);
        complete(&ar->wmi.unified_ready);
        return 0;
 }