greybus: Add FIXME warnings for possible NULL dereferences

Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c
index 44cfd50..f014906 100644 (file)
--- a/drivers/staging/greybus/operation.c
+++ b/drivers/staging/greybus/operation.c
@@ -742,6 +742,7 @@ int gb_operation_response_send(struct gb_operation *operation, int errno)
                }
        }
 
+       /* FIXME operation->response could still be NULL here */
        /* Fill in the response header and send it */
        operation->response->header->result = gb_operation_errno_map(errno);
 

diff --git a/drivers/staging/greybus/protocol.c b/drivers/staging/greybus/protocol.c
index 562401d..b8ae707 100644 (file)
--- a/drivers/staging/greybus/protocol.c
+++ b/drivers/staging/greybus/protocol.c
@@ -188,6 +188,9 @@ void gb_protocol_put(struct gb_protocol *protocol)
        if (protocol)
                WARN_ON(!protocol_count);
        else
+               /* FIXME a different message is needed since this one
+                * will result in a NULL dereference
+                */
                pr_err("protocol id %hhu version %hhu.%hhu not found\n",
                        protocol->id, major, minor);
 }