OSDN Git Service

crypto: caam - Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Sep 2020 19:29:17 +0000 (21:29 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Sep 2020 07:20:12 +0000 (17:20 +1000)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/caamalg_qi2.c

index 0441e4f..076c6b0 100644 (file)
@@ -5115,8 +5115,7 @@ static int dpaa2_caam_probe(struct fsl_mc_device *dpseci_dev)
        /* DPIO */
        err = dpaa2_dpseci_dpio_setup(priv);
        if (err) {
-               if (err != -EPROBE_DEFER)
-                       dev_err(dev, "dpaa2_dpseci_dpio_setup() failed\n");
+               dev_err_probe(dev, err, "dpaa2_dpseci_dpio_setup() failed\n");
                goto err_dpio_setup;
        }